Draft
Conversation
…n-sdk into feat/PT9-137-transfer-permit
edvardg
reviewed
Mar 27, 2026
|
|
||
| // todo: update | ||
| const PERMIT2_PROXY_ADDRESS = '0xcf56da25062c954b252515244dfefb739c254c23' | ||
| const PERMIT2_PROXY_ADDRESS_ZK = '0x0000000000000000000000000000000000000000' |
Contributor
There was a problem hiding this comment.
Let's keep this in mind and update once we have the correct addresses
|
|
||
| export const ONE_INCH_LIMIT_ORDER_V4 = | ||
| '0x111111125421ca6dc452d289314280a0f8842a65' | ||
| export const ONE_INCH_LIMIT_ORDER_V4_ADDRESSES: Record<NetworkEnum, string> = { |
Contributor
There was a problem hiding this comment.
We replaced ONE_INCH_LIMIT_ORDER_V4 with ONE_INCH_LIMIT_ORDER_V4_ADDRESSES - sounds like a breaking change as it could be used by customers.
I'd suggest keeping ONE_INCH_LIMIT_ORDER_V4 as deprecated, and suggesting ONE_INCH_LIMIT_ORDER_V4_ADDRESSES usage.
…n-sdk into feat/PT9-137-transfer-permit
krboktv
requested changes
Mar 27, 2026
Comment on lines
+23
to
+25
| // todo: update | ||
| const PERMIT2_PROXY_ADDRESS = '0xcf56da25062c954b252515244dfefb739c254c23' | ||
| const PERMIT2_PROXY_ADDRESS_ZK = '0x0000000000000000000000000000000000000000' |
Member
There was a problem hiding this comment.
Don't forget to update addresses
…n-sdk into feat/PT9-137-transfer-permit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What does this PR change?
Add support of Permit2
PermitTransferFromTesting & Verification
How was this tested?
Risk Assessment
Risk Level:
Risks & Impact